src: prefer make_unique #33378
Closed
src: prefer make_unique #33378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most of the code base we use make_unique instead of new unique_ptr. Update node_platform.cc to be consistent with that. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs-github-bot
added
the
c++
addaleax
approved these changes
May 12, 2020
jasnell
approved these changes
May 12, 2020
cjihrig
approved these changes
May 12, 2020
himself65
approved these changes
May 13, 2020
|
Looks to me like CI failures are unrelated as they are in a file not changed by this PR, like due to enabling warnings as errors. Will launch another CI once the waiting time has passed. |
juanarbol
approved these changes
May 20, 2020
addaleax
added
the
author ready
|
Latest CI run looks good, landing |
mhdawson
added a commit
that referenced
this pull request
May 20, 2020
In most of the code base we use make_unique instead of new unique_ptr. Update node_platform.cc to be consistent with that. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #33378 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Landed in 4c4c226 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
In most of the code base we use make_unique instead of new unique_ptr. Update node_platform.cc to be consistent with that. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #33378 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 6, 2020
In most of the code base we use make_unique instead of new unique_ptr. Update node_platform.cc to be consistent with that. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #33378 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most of the code base we use make_unique instead of
new unique_ptr. Update node_platform.cc to be consistent
with that.
Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes