Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused misc variable #33417

Closed
wants to merge 2 commits into from

Conversation

danbev
Copy link
Member

@danbev danbev commented May 15, 2020

This commit removes the unused misc variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels May 15, 2020
@nodejs-github-bot
Copy link
Collaborator

danbev added a commit that referenced this pull request May 18, 2020
This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit that referenced this pull request May 18, 2020
PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Member Author

danbev commented May 18, 2020

Landed in ebffd22, and ef1eb8d.

@danbev danbev closed this May 18, 2020
@danbev danbev deleted the node_main_instance-remove-misc branch May 18, 2020 05:28
codebytere pushed a commit that referenced this pull request May 21, 2020
This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request May 21, 2020
PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 7, 2020
This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 7, 2020
PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 9, 2020
This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
PR-URL: nodejs#33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
@codebytere codebytere mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants