Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to uvwasi 0.0.9 #33445

Closed
wants to merge 1 commit into from
Closed

deps: update to uvwasi 0.0.9 #33445

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 17, 2020

Notable changes:

  • A DEBUG() macro and UVWASI_DEBUG_LOG build option have been
    added to improve debugging.
  • Path length restrictions have been removed across the codebase.
  • Initial support for poll_oneoff() has been added on all
    platforms. The implementation is based on uv_poll_t's.
  • A new uvwasi_size_t has been introduced across the WASI system
    call API. This provides consistent 32-bit size_t's.
  • The cmake test targets are now only generated if uvwasi is the
    root project to avoid conflicts with targets from embedders.
  • uv.h has been removed from the public headers.
  • A serialization/deserialization API has been added to simplify
    the process of working with WASM memory. This also hides many
    WASI <--> WASM interfacing implementation details from
    embedders.
  • A memory corruption bug on Windows related to path resolution
    has been fixed.

Fixes: #33403

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Notable changes:

- A `DEBUG()` macro and `UVWASI_DEBUG_LOG` build option have been
  added to improve debugging.
- Path length restrictions have been removed across the codebase.
- Initial support for `poll_oneoff()` has been added on all
  platforms. The implementation is based on `uv_poll_t`'s.
- A new `uvwasi_size_t` has been introduced across the WASI system
  call API. This provides consistent 32-bit `size_t`'s.
- The cmake test targets are now only generated if uvwasi is the
  root project to avoid conflicts with targets from embedders.
- `uv.h` has been removed from the public headers.
- A serialization/deserialization API has been added to simplify
  the process of working with WASM memory. This also hides many
  WASI <--> WASM interfacing implementation details from
  embedders.
- A memory corruption bug on Windows related to path resolution
  has been fixed.
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 17, 2020
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 19, 2020

@cjihrig
Copy link
Contributor Author

cjihrig commented May 19, 2020

cc: @nodejs/wasi

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2020
@addaleax
Copy link
Member

Landed in 3abb52f

addaleax pushed a commit that referenced this pull request May 19, 2020
Notable changes:

- A `DEBUG()` macro and `UVWASI_DEBUG_LOG` build option have been
  added to improve debugging.
- Path length restrictions have been removed across the codebase.
- Initial support for `poll_oneoff()` has been added on all
  platforms. The implementation is based on `uv_poll_t`'s.
- A new `uvwasi_size_t` has been introduced across the WASI system
  call API. This provides consistent 32-bit `size_t`'s.
- The cmake test targets are now only generated if uvwasi is the
  root project to avoid conflicts with targets from embedders.
- `uv.h` has been removed from the public headers.
- A serialization/deserialization API has been added to simplify
  the process of working with WASM memory. This also hides many
  WASI <--> WASM interfacing implementation details from
  embedders.
- A memory corruption bug on Windows related to path resolution
  has been fixed.

PR-URL: #33445
Fixes: #33403
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@addaleax addaleax closed this May 19, 2020
@cjihrig cjihrig deleted the uvwasi branch May 20, 2020 13:31
codebytere pushed a commit that referenced this pull request May 21, 2020
Notable changes:

- A `DEBUG()` macro and `UVWASI_DEBUG_LOG` build option have been
  added to improve debugging.
- Path length restrictions have been removed across the codebase.
- Initial support for `poll_oneoff()` has been added on all
  platforms. The implementation is based on `uv_poll_t`'s.
- A new `uvwasi_size_t` has been introduced across the WASI system
  call API. This provides consistent 32-bit `size_t`'s.
- The cmake test targets are now only generated if uvwasi is the
  root project to avoid conflicts with targets from embedders.
- `uv.h` has been removed from the public headers.
- A serialization/deserialization API has been added to simplify
  the process of working with WASM memory. This also hides many
  WASI <--> WASM interfacing implementation details from
  embedders.
- A memory corruption bug on Windows related to path resolution
  has been fixed.

PR-URL: #33445
Fixes: #33403
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 9, 2020
Notable changes:

- A `DEBUG()` macro and `UVWASI_DEBUG_LOG` build option have been
  added to improve debugging.
- Path length restrictions have been removed across the codebase.
- Initial support for `poll_oneoff()` has been added on all
  platforms. The implementation is based on `uv_poll_t`'s.
- A new `uvwasi_size_t` has been introduced across the WASI system
  call API. This provides consistent 32-bit `size_t`'s.
- The cmake test targets are now only generated if uvwasi is the
  root project to avoid conflicts with targets from embedders.
- `uv.h` has been removed from the public headers.
- A serialization/deserialization API has been added to simplify
  the process of working with WASM memory. This also hides many
  WASI <--> WASM interfacing implementation details from
  embedders.
- A memory corruption bug on Windows related to path resolution
  has been fixed.

PR-URL: #33445
Fixes: #33403
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
codebytere added a commit that referenced this pull request Jun 16, 2020
Notable changes:

deps:
  * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](#33484)
  * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](#33445)
  * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](#33446)
  * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](#33239)

PR-URL: #33811
codebytere added a commit that referenced this pull request Jun 16, 2020
Notable changes:

deps:
  * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](#33484)
  * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](#33445)
  * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](#33446)
  * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](#33239)

PR-URL: #33811
codebytere added a commit that referenced this pull request Jun 17, 2020
Notable changes:

deps:
  * V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) [#33484](#33484)
  * update to uvwasi 0.0.9 (Colin Ihrig) [#33445](#33445)
  * upgrade to libuv 1.38.0 (Colin Ihrig) [#33446](#33446)
  * upgrade npm to 6.14.5 (Ruy Adorno) [#33239](#33239)

PR-URL: #33811
codebytere added a commit to electron/electron that referenced this pull request Jun 18, 2020
@codebytere codebytere mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants