v14.3.0 proposal #33452
Merged
v14.3.0 proposal #33452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #29394 Refs: #33167 (comment) PR-URL: #33190 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: then/is-promise#20 PR-URL: #33074 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Instead of passing them through the data bound to function templates, store references to them in a list embedded inside the context. This makes the function templates more context-independent, and makes it possible to embed binding data in non-main contexts. Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: #33139 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](#32379). Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33102 Refs: https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763 Reviewed-By: Anna Henningsen <anna@addaleax.net>
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #33037 PR-URL: #33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Fixes: #33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #33181 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: #29428 PR-URL: #33201 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: #33117 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33252 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: #33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #33248 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #33235 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33230 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33224 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #33217 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This enables loading this module during early bootstrapping. PR-URL: #33212 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
It returns zero-filled memory since v8.0.0. PR-URL: #33198 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #33179 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Ran into #30189, solved by this comment: #30189 (comment) Refs: #30189 PR-URL: #33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #33211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add capabilities to common test module to detect and skip tests
on dumb terminals.
In some of our build environments, like s390x, the terminal
is a dumb terminal meaning it has very rudimentary capabilities.
These in turn prevent some of the tests from completing with errors
as below.
not ok 1777 parallel/test-readline-tab-complete
---
duration_ms: 0.365
severity: fail
exitcode: 1
stack: |-
assert.js:103
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
'\t' !== ''
at /home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:63:14
at Array.forEach (<anonymous>)
at /home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:18:17
at Array.forEach (<anonymous>)
at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:17:3)
at Module._compile (internal/modules/cjs/loader.js:1176:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
at Module.load (internal/modules/cjs/loader.js:1040:32)
at Function.Module._load (internal/modules/cjs/loader.js:929:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: '\t',
expected: '',
operator: 'strictEqual'
}
...
PR-URL: #33165
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Calling `decipher.setAuthTag` after `decipher.update` will result in an error like `Unsupported state or unable to authenticate data`. The example code in [CCM mode](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode) is correct, but to demonstrate the mistake in the documentation you can take the same example and move the `setAuthTag` call to in between `update` and `final` you will see the error.
* Initialize structure members. * Factor out common `Debug()` prefix. * Remove unused `text_region` field. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #33255 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: #33250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Jan 25, 2022
This was referenced Sep 27, 2022
This was referenced Sep 28, 2022
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-05-19, Version 14.3.0 (Current), @codebytere
Notable Changes
7aa581f4ff] - (SEMVER-MINOR) repl: deprecate repl._builtinLibs (Ruben Bridgewater) #33294ed83202307] - (SEMVER-MINOR) repl: remove obsolete completer variable (Ruben Bridgewater) #33294db7bb941a3] - (SEMVER-MINOR) repl: deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) #332942dc5db8c07] - (SEMVER-MINOR) cli: add--trace-atomics-waitflag (Anna Henningsen) #332926257cf256e] - (SEMVER-MINOR) repl: improve repl autocompletion for require calls (Ruben Bridgewater) #3328295842db17e] - (SEMVER-MINOR) test: refactor test/parallel/test-bootstrap-modules.js (Ruben Bridgewater) #3328269061dc73e] - (SEMVER-MINOR) repl: replace hard coded core module list with actual list (Ruben Bridgewater) #33282d33dcf1d5f] - (SEMVER-MINOR) repl: show reference errors during preview (Ruben Bridgewater) #332821a9771a50a] - (SEMVER-MINOR) repl: improve repl preview (Ruben Bridgewater) #332820d77eec4b0] - src: add support for TLA (Gus Caplan) #303701dcf66cf87] - (SEMVER-MINOR) fs: add .ref() and .unref() methods to watcher classes (rickyes) #33134f33e86649e] - (SEMVER-MINOR) http: expose http.validate-header-name/value (osher) #33119b06165584e] - (SEMVER-MINOR) async_hooks: move PromiseHook handler to JS (Stephen Belanger) #32891Commits
dd4789b8ee] - async_hooks: clear async_id_stack for terminations in more places (Anna Henningsen) #33347b06165584e] - (SEMVER-MINOR) async_hooks: move PromiseHook handler to JS (Stephen Belanger) #32891cae2051b83] - buffer: improve copy() performance (Nikolai Vavilov) #3321424faa37a09] - buffer,n-api: release external buffers from BackingStore callback (Anna Henningsen) #3332134e7400fc1] - build: enable--error-on-warnfor POSIX workflows (Richard Lau) #333577d4db35f84] - build: fix--error-on-warnfor macOS (Richard Lau) #333572dc5db8c07] - (SEMVER-MINOR) cli: add--trace-atomics-waitflag (Anna Henningsen) #33292331f0b3420] - deps: update to ICU 67.1 (Michaël Zasso) #33324ba66b21c37] - deps: upgrade npm to 6.14.5 (Ruy Adorno) #33239cc279490ce] - doc: prepare 14.x changelog for remark update (Rich Trott) #334127f9ccd6d89] - doc: fix extension in esm example (Gus Caplan) #334088f91338f6e] - doc: fix stream example (Anna Henningsen) #33426182aaf5622] - doc: enhance guides by fixing and making grammar more consistent (Chris Holland) #331520ffa0402a5] - doc: add examples for implementing ESM (unknown) #33168b41affb9e2] - doc: add note about clientError writable handling (Paolo Insogna) #333084f0cd648bb] - doc: fix typo in n-api.md (Daniel Bevenius) #333190cbee57109] - doc: add warning for socket.connect reuse (Robert Nagy) #33204a9e4fdbd1b] - doc: correct description ofdecipher.setAuthTagin crypto.md (Jonathan Buhacoff)84974d3f2c] - doc: mention python3-distutils dependency in BUILDING.md (osher) #33174b5dcfbf634] - doc: removed unnecessary util imports from vm examples (Karol Walasek) #33179e20fe535a5] - doc: update Buffer(size) documentation (Nikolai Vavilov) #331985b42d812cc] - doc: add Uint8Array toendandwrite(Pranshu Srivastava) #33217c6a8cd0fa1] - doc: fix md issue in src/README.md (Juan José Arboleda) #332242c49dd3d01] - doc: specify unit of time passed tofs.utimes(Simen Bekkhus) #332306ffec50494] - doc: add troubleshooting guide for AsyncLocalStorage (Andrey Pechkurov) #33248dab5c38f98] - doc: remove AsyncWrap mentions from async_hooks.md (Andrey Pechkurov) #3324905729430bf] - doc: add warnings about transferring Buffers and ArrayBuffer (James M Snell) #33252cf88ed8664] - doc: update napi_async_init documentation (Michael Dawson) #3318125443fa7f2] - doc: doc and test URLSearchParams discrepancy (James M Snell) #3323607372e9d5b] - doc: explicitly doc package.exports is breaking (Myles Borins) #33074c5a38fe6d7] - doc: fix style and grammer in buffer.md (Nikolai Vavilov) #33194e53de96a89] - esm: improve commonjs hint on module not found (Antoine du Hamel) #33220c7c420ec87] - fs: forbid concurrent operations on Dir handle (Anna Henningsen) #3327412391c7a20] - fs: clean up Dir.read() uv_fs_t data before calling into JS (Anna Henningsen) #332741dcf66cf87] - (SEMVER-MINOR) fs: add .ref() and .unref() methods to watcher classes (rickyes) #33134f33e86649e] - (SEMVER-MINOR) http: expose http.validate-header-name/value (osher) #33119cc5c8e039d] - http: don't destroy completed request (Robert Nagy) #33120b634d4b000] - http: set IncomingMessage.destroyed (Robert Nagy) #33131cc02c73e53] - http: fixes memory retention issue with FreeList and HTTPParser (John Leidegren) #3319041c5524432] - http2: addbytesWrittentest forHttp2Stream(Pranshu Srivastava) #33162a133a88234] - lib: fix typo in timers insert function comment (Daniel Bevenius) #3330194d0a088ec] - lib: refactored scheduling policy assignment (Yash Ladha) #326636bca487b8b] - lib: fix grammar in internal/bootstrap/loaders.js (szTheory) #332110a78925146] - meta: add issue template for API reference docs (Derek Lewis) #3294435aae31968] - module: add specific error for dir import (Antoine du HAMEL) #33220c2d2dfc09f] - module: do not check circular dependencies for exported proxies (Ruben Bridgewater) #33338ad8680773e] - module: better error for named exports from cjs (Myles Borins) #3325627b814c79b] - module: lazy load 'getOptionValue' in initializeLoader (himself65) #332124ae6130010] - n-api: add uint32 test for -1 (Gabriel Schulhof)398bdf40e5] - perf_hooks: fix error message for invalid entryTypes (Michaël Zasso) #332857aa581f4ff] - (SEMVER-MINOR) repl: deprecate repl._builtinLibs (Ruben Bridgewater) #33294ed83202307] - (SEMVER-MINOR) repl: remove obsolete completer variable (Ruben Bridgewater) #33294db7bb941a3] - (SEMVER-MINOR) repl: deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) #332946257cf256e] - (SEMVER-MINOR) repl: improve repl autocompletion for require calls (Ruben Bridgewater) #3328269061dc73e] - (SEMVER-MINOR) repl: replace hard coded core module list with actual list (Ruben Bridgewater) #33282d33dcf1d5f] - (SEMVER-MINOR) repl: show reference errors during preview (Ruben Bridgewater) #332821a9771a50a] - (SEMVER-MINOR) repl: improve repl preview (Ruben Bridgewater) #33282099f18e89b] - src: distinguish refed/unrefed threadsafe Immediates (Anna Henningsen) #333205e5aa0bc6c] - src: add #include <string> in json_utils.h (Cheng Zhao) #333328ada953ef2] - src: replace to CHECK_NOT_NULL in node_crypto (himself65) #333830257386cd4] - src: remove deprecated FinalizationRegistry hooks (Gus Caplan) #33373354ff4f21b] - src: small modification to NgHeader (James M Snell) #33289fd89ef1478] - src: refactor Reallocate since it introduced in upstream v8 (Jiawen Geng) #33402d292633ed4] - src: add primordials to arguments comment (Daniel Bevenius) #3331819996073ca] - src: remove unused using declarations in node.cc (Daniel Bevenius) #33261c9c16c03c4] - src: delete unused variables to resolve compile time print warning (rickyes) #33358066ca98069] - src: use MaybeLocal.ToLocal instead of IsEmpty (Daniel Bevenius) #33312f3129b290d] - src: fix typo in comment in async_wrap.cc (Daniel Bevenius) #333500d77eec4b0] - src: add support for TLA (Gus Caplan) #30370fd9c7c2118] - src: fix compiler warning in async_wrap.cc (Anna Henningsen) #333223de9dd9c8d] - src: remove unnecessary Isolate::GetCurrent() calls (Anna Henningsen) #33298ef2503375b] - src: fix invalid windowBits=8 gzip segfault (Ben Noordhuis) #33045548cedd870] - src: split out callback queue implementation from Environment (Anna Henningsen) #33272ed41494397] - src: clean up large pages code (Gabriel Schulhof) #33255cf476984f6] - src: use BaseObjectPtr in StreamReq::Dispose (James M Snell) #331025ff31921cc] - Revert "src: add test/abort build tasks" (Richard Lau) #33196a56b600e93] - Revert "src: add aliased-buffer-overflow abort test" (Richard Lau) #33196a292630baf] - src: retrieve binding data from the context (Joyee Cheung) #33139b2fb01a68d] - stream: make from read one at a time (Robert Nagy) #33201b93a723fe6] - test: regression tests for async_hooks + Promise + Worker interaction (Anna Henningsen) #33347d3e2fc81e8] - test: fix test-dns-idna2008 (Rich Trott) #3336795842db17e] - (SEMVER-MINOR) test: refactor test/parallel/test-bootstrap-modules.js (Ruben Bridgewater) #33282f31b262f50] - test: refactor WPTRunner (Joyee Cheung) #3329785cffb8e4c] - test: update WPT interfaces and hr-time (Joyee Cheung) #332975b2cd440a1] - test: fix test-net-throttle (Rich Trott) #333291d2c81fee9] - test: add hr-time Web platform tests (Michaël Zasso) #332876f54c2bbb6] - test: rename test-lookupService-promises (rickyes) #33100302408e515] - test: skip some console tests on dumb terminal (Adam Majer) #33165676ef952ab] - test: add tests for options.fs in fs streams (Julian Duque) #331856d2aaaf6b4] - tls: fix --tls-keylog option (Alba Mendez) #33366eedc13174e] - tls: reset secureConnecting on client socket (David Halls) #33209453affebb0] - tools: update dependencies for markdown linting (Rich Trott) #3341291193447fb] - tools: enable no-else-return lint rule (Luigi Pinca) #32667e1e57a4223] - tools: update ESLint to 7.0.0 (Colin Ihrig) #33316cf03fe5b67] - tools: remove obsolete no-restricted-syntax eslint rules (Ruben Bridgewater) #32161804982c1b6] - tools: add eslint rule to only pass through 'test' to debuglog (Ruben Bridgewater) #32161c2cf9782ab] - Revert "vm: add importModuleDynamically option to compileFunction" (Matteo Collina) #333646a26eee3c5] - wasi: fix poll_oneoff memory interface (Colin Ihrig) #332504465d23c30] - wasi: prevent syscalls before start (Tobias Nießen) #332359d1e577109] - worker: fix crash when .unref() is called during exit (Anna Henningsen) #33394b1a7fdac43] - worker: call CancelTerminateExecution() before exiting Locker (Anna Henningsen) #33347736ca65c2c] - zlib: reject windowBits=8 when mode=GZIP (Ben Noordhuis) #33045