Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: make dns.Resolver timeout configurable #33472

Closed
wants to merge 4 commits into from
Closed

dns: make dns.Resolver timeout configurable #33472

wants to merge 4 commits into from

Conversation

bnoordhuis
Copy link
Member

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dns Issues and PRs related to the dns subsystem. labels May 19, 2020
@bnoordhuis
fixup! update pr-url
b4cac47
@bnoordhuis
fixup! clamp timeout at 1000 ms
eae2cfc 
otherwise it's a possible observable change in behavior
jasnell
jasnell reviewed May 22, 2020
View reviewed changes
lib/internal/dns/utils.js Outdated Show resolved Hide resolved
@bnoordhuis @jasnell
Update lib/internal/dns/utils.js
7941e84 
Co-authored-by: James M Snell <jasnell@gmail.com>
BridgeAR
BridgeAR reviewed May 30, 2020
View reviewed changes
doc/api/dns.md Show resolved Hide resolved
lib/internal/dns/utils.js Show resolved Hide resolved
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 31, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31681/

jasnell pushed a commit that referenced this pull request Jun 1, 2020
@bnoordhuis @jasnell
dns: make dns.Resolver timeout configurable
1904e73 
PR-URL: #33472
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 1, 2020

Landed in 1904e73

@jasnell jasnell closed this Jun 1, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@bnoordhuis @codebytere
dns: make dns.Resolver timeout configurable
d4442b1 
PR-URL: #33472
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@bnoordhuis @codebytere
dns: make dns.Resolver timeout configurable
c44b504 
PR-URL: #33472
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@bnoordhuis @codebytere
dns: make dns.Resolver timeout configurable
5d3f818 
PR-URL: #33472
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dns Issues and PRs related to the dns subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bnoordhuis @nodejs-github-bot @jasnell @addaleax @cjihrig @gengjiawen @BridgeAR