Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write #33490

Closed
wants to merge 3 commits into from
Closed

[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write #33490

wants to merge 3 commits into from

Commits on May 20, 2020

  1. http: don't throw on Uint8Arrays for http.ServerResponse#write 

    Don't throw errors on Uint8Arrays and added test for all
valid types.

Backport-PR-URL: nodejs#33490
PR-URL: nodejs#33155
Fixes: nodejs#33379
Refs: nodejs#29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @rexagod
    rexagod committed May 20, 2020
    Configuration menu
    Copy the full SHA
    4732f15 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. remove semver major changes

    @rexagod
    rexagod committed May 30, 2020
    Configuration menu
    Copy the full SHA
    d749443 View commit details
    Browse the repository at this point in the history

  2. fixup

    @rexagod
    rexagod committed May 30, 2020
    Configuration menu
    Copy the full SHA
    e07ef0b View commit details
    Browse the repository at this point in the history