Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: unify style in preprocessSymlinkDestination #33496

Closed
wants to merge 1 commit into from
Closed

fs: unify style in preprocessSymlinkDestination #33496

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented May 21, 2020

Removes the else after return to match rest of the style of the function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@bzoz
fs: unify style in preprocessSymlinkDestination
499bcf5 
Removes the else after return to match rest of the style of
the function.
@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label May 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31482/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 23, 2020
@bzoz @BridgeAR
fs: unify style in preprocessSymlinkDestination
4a911d4 
Removes the else after return to match rest of the style of
the function.

PR-URL: nodejs#33496
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 4a911d4 🎉

@BridgeAR BridgeAR closed this May 23, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@bzoz @codebytere
fs: unify style in preprocessSymlinkDestination
d1a5732 
Removes the else after return to match rest of the style of
the function.

PR-URL: #33496
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@bzoz @codebytere
fs: unify style in preprocessSymlinkDestination
2c03661 
Removes the else after return to match rest of the style of
the function.

PR-URL: #33496
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@bzoz @codebytere
fs: unify style in preprocessSymlinkDestination
837eb2a 
Removes the else after return to match rest of the style of
the function.

PR-URL: #33496
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@bzoz @codebytere
fs: unify style in preprocessSymlinkDestination
adb93f1 
Removes the else after return to match rest of the style of
the function.

PR-URL: #33496
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bzoz @nodejs-github-bot @BridgeAR @jasnell @cjihrig