Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-dgram-multicast-ssmv6-multi-process flaky #33498

Closed
wants to merge 1 commit into from
Closed

test: mark test-dgram-multicast-ssmv6-multi-process flaky #33498

wants to merge 1 commit into from

Conversation

AshCripps
Copy link
Member

refs: #32946

Mark this test as flaky on linux as its been failing test-commit-custom-suites-freestylefor a while

Ive used sequential.status as a template for this file.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 21, 2020
test: mark test-dgram-multicast-ssmv6-multi-process flaky
eaef98e 
refs: nodejs#32946

Mark this test as flaky on linux
Ive used sequential.status as a template for this file
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31464/

richardlau
richardlau approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Since this is in internet this must be failing during the daily runs? In which case you may need to check how that job is treating flaky tests (i.e. is --flaky-tests= being set for the test harness).

@sam-github
Copy link
Contributor

the daily triggers this through https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/configure, and it looks good

python tools/test.py -j $JOBS -p tap --logfile test.tap --mode=release --flaky-tests=dontcare $TEST_ARGS $CI_JS_SUITES

@sam-github
Copy link
Contributor

I propose fast-tracking if CI is green for the PR.

@sam-github sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label May 21, 2020
@codebytere codebytere mentioned this pull request May 22, 2020
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31471/

sam-github pushed a commit that referenced this pull request May 22, 2020
@sam-github
test: mark test-dgram-multicast-ssmv6-multi-process flaky
e14786f 
refs: #32946

Mark this test as flaky on linux
Ive used sequential.status as a template for this file

PR-URL: #33498
Refs: #32946
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@sam-github
Copy link
Contributor

Landed in e14786f

@sam-github sam-github closed this May 22, 2020
@AshCripps AshCripps deleted the mark-flaky-dgram-test branch May 22, 2020 21:42
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@codebytere
test: mark test-dgram-multicast-ssmv6-multi-process flaky
eb877a4 
refs: #32946

Mark this test as flaky on linux
Ive used sequential.status as a template for this file

PR-URL: #33498
Refs: #32946
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@codebytere
test: mark test-dgram-multicast-ssmv6-multi-process flaky
d0bfbd6 
refs: #32946

Mark this test as flaky on linux
Ive used sequential.status as a template for this file

PR-URL: #33498
Refs: #32946
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@codebytere
test: mark test-dgram-multicast-ssmv6-multi-process flaky
ef27e6c 
refs: #32946

Mark this test as flaky on linux
Ive used sequential.status as a template for this file

PR-URL: #33498
Refs: #32946
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AshCripps @nodejs-github-bot @sam-github @lpinca @richardlau