wasi: refactor and enable poll_oneoff() test #33521
Merged
+60
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
May 23, 2020
BridgeAR
added
the
author ready
|
@nodejs/wasi ping for another review |
gengjiawen
approved these changes
May 25, 2020
Original commit message:
poll_oneoff: add missing uv_run() in cleanup
This allows ASAN to pass.
PR-URL: nodejs#33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This commit refactors and enables the poll_oneoff() WASI test. The refactor includes testing additional cases, as well as some platform specific checks. PR-URL: nodejs#33521 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in c072124...a4e6ef7. Thanks for the reviews! |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Original commit message:
poll_oneoff: add missing uv_run() in cleanup
This allows ASAN to pass.
PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit refactors and enables the poll_oneoff() WASI test. The refactor includes testing additional cases, as well as some platform specific checks. PR-URL: #33521 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Original commit message:
poll_oneoff: add missing uv_run() in cleanup
This allows ASAN to pass.
PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This commit refactors and enables the poll_oneoff() WASI test. The refactor includes testing additional cases, as well as some platform specific checks. PR-URL: #33521 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
Original commit message:
poll_oneoff: add missing uv_run() in cleanup
This allows ASAN to pass.
PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit refactors and enables the poll_oneoff() WASI test. The refactor includes testing additional cases, as well as some platform specific checks. PR-URL: #33521 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
codebytere
added a commit
that referenced
this pull request
Jul 13, 2020
codebytere
added a commit
that referenced
this pull request
Jul 14, 2020
codebytere
added a commit
that referenced
this pull request
Jul 21, 2020
codebytere
added a commit
that referenced
this pull request
Jul 21, 2020
codebytere
added a commit
that referenced
this pull request
Jul 22, 2020
codebytere
added a commit
that referenced
this pull request
Jul 22, 2020
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors and enables the
poll_oneoff()WASI test.The refactor includes testing additional cases, as well as some
platform specific checks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes