Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make flaky test stricter #33539

Closed
wants to merge 1 commit into from
Closed

test: make flaky test stricter #33539

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented May 24, 2020 •
edited

Refs: #4066

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 24, 2020
@ronag
Copy link
Member Author

ronag commented May 24, 2020 •
edited

https://ci.nodejs.org/job/node-stress-single-test/77/

@ronag ronag added the http Issues or PRs related to the http subsystem. label May 24, 2020
@ronag
test: make flaky test stricter
16495c1 
Make assertions in flaky test stricter to possibly
make it easier to determine the root cause.

Refs: nodejs#4066
@ronag ronag changed the title test: try to resolve flaky test test: make flaky test strict May 25, 2020
@ronag ronag marked this pull request as ready for review May 25, 2020 06:52
@ronag ronag changed the title test: make flaky test strict test: make flaky test stricter May 25, 2020
@ronag ronag requested a review from BridgeAR May 25, 2020 06:52
@ronag
Copy link
Member Author

ronag commented May 25, 2020

Haven't been able to make the flaky test fail to debug this and it's unclear how it hits the failure. I've made the test a bit stricter hoping that future failures maight provide more information.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31546/

@BridgeAR
Copy link
Member

The error that came up was ERR_STREAM_DESTROYED. It is not clear why the stream was destroyed but this might of course help debugging.

@ronag
Copy link
Member Author

ronag commented May 25, 2020

The error that came up was ERR_STREAM_DESTROYED. It is not clear why the stream was destroyed but this might of course help debugging.

Yes, but that should not happen unless it gets into the "response" state. Which this change ensures it should not.

BridgeAR
BridgeAR approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR BridgeAR requested review from lpinca and mcollina May 25, 2020 13:42
mcollina
mcollina approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2020
@ronag
Copy link
Member Author

ronag commented May 26, 2020

Landed in 9949a2e

ronag added a commit that referenced this pull request May 26, 2020
@ronag
test: make flaky test stricter
9949a2e 
Make assertions in flaky test stricter to possibly
make it easier to determine the root cause.

Refs: #4066

PR-URL: #33539
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ronag ronag closed this May 26, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@ronag @codebytere
test: make flaky test stricter
da5e970 
Make assertions in flaky test stricter to possibly
make it easier to determine the root cause.

Refs: #4066

PR-URL: #33539
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@ronag @codebytere
test: make flaky test stricter
9e1fb0f 
Make assertions in flaky test stricter to possibly
make it easier to determine the root cause.

Refs: #4066

PR-URL: #33539
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@ronag @codebytere
test: make flaky test stricter
3032f0f 
Make assertions in flaky test stricter to possibly
make it easier to determine the root cause.

Refs: #4066

PR-URL: #33539
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ronag @nodejs-github-bot @BridgeAR @mcollina @jasnell @lpinca