Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] deps: V8: backport fb26d0bb1835 #33573

Closed

Commits on Jun 17, 2020

  1. deps: V8: backport fb26d0bb1835

    Original commit message:
    
        [objects] Compact and shrink script_list
    
        So far creating scripts always grew the script_list without ever
        reusing cleared slots or shrinking. While this is probably not a
        problem with script_list in practice, this is still a memory leak.
    
        Fix this leak by using WeakArrayList::Append instead of AddToEnd.
        Append adds to the end of the array, but potentially compacts and
        shrinks the list as well. Other WeakArrayLists can use this method as
        well, as long as they are not using indices into this array.
    
        Bug: v8:10031
        Change-Id: If743c4cc3f8d67ab735522f0ded038b2fb43e437
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967385
        Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#65640}
    
    Refs: v8/v8@fb26d0b
    mmarchini committed Jun 17, 2020
    Copy the full SHA
    1f9566b View commit details
    Browse the repository at this point in the history