napi: add __wasm32__ guards #33597
Merged
napi: add __wasm32__ guards #33597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
devsnek
force-pushed
the
wasm-napi-headers
branch
from
6b1c08f
to
92f4cfe
Compare
jasnell
approved these changes
May 29, 2020
BridgeAR
added
the
author ready
cjihrig
approved these changes
May 30, 2020
PR-URL: nodejs#33597 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
devsnek
force-pushed
the
wasm-napi-headers
branch
from
92f4cfe
to
b4ede54
Compare
tniessen
reviewed
Jun 4, 2020
| napi_value exports) { \ | ||
| return regfunc(env, exports); \ | ||
| } \ | ||
| EXTERN_C_END |
There was a problem hiding this comment.
Why is this change necessary? Just to have a predictable function name?
There was a problem hiding this comment.
right, the napi js impl calls this as a replacement for node's native_module registration api
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33597 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33597 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
PR-URL: #33597 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
PR-URL: #46633 Refs: #33597 Refs: nodejs/node-addon-api#1283 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46633 Refs: #33597 Refs: nodejs/node-addon-api#1283 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46633 Refs: #33597 Refs: nodejs/node-addon-api#1283 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes