Update root certs to use NSS 3.53 #33682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2020 13:31
This is the certdata.txt[0] from NSS 3.53, released on 2020-05-29. This is the version of NSS that will ship in Firefox 78 on 2020-06-30. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_53_RTM/lib/ckfw/builtins/certdata.txt
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: Entrust Root Certification Authority - G4 Certificates removed:
nodejs-github-bot
added
c++
jasnell
approved these changes
Jun 1, 2020
sam-github
approved these changes
Jun 1, 2020
|
cc: @nodejs/security |
sam-github
added
security
BethGriggs
approved these changes
Jun 1, 2020
|
fast-track, to get this in the security release tomorrow? |
sam-github
added
the
fast-track
addaleax
added
author ready
|
I'll watch the build status and merge when its green. cc: @targos @BethGriggs |
juanarbol
approved these changes
Jun 1, 2020
|
Landed in 41796eb...f1ae7ea |
sam-github
pushed a commit
that referenced
this pull request
Jun 1, 2020
This is the certdata.txt[0] from NSS 3.53, released on 2020-05-29. This is the version of NSS that will ship in Firefox 78 on 2020-06-30. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_53_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #33682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
sam-github
pushed a commit
that referenced
this pull request
Jun 1, 2020
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: Entrust Root Certification Authority - G4 Certificates removed: PR-URL: #33682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
I'm not sure if this should land on v10.x, @nodejs/lts 10.x currently has NSS 3.41. It is missing the master updates to 3.42, 3.45, 3.47, so this PR's update to 3.53 won't land cleanly. What is the LTS release policy wrt. certificate data updates? |
|
I don't think we have a specific policy for updating the certificates but in my opinion it falls under the security updates category. |
Closed
3 tasks
nornagon
added a commit
to electron/electron
that referenced
this pull request
Jun 23, 2020
3 tasks
nornagon
added a commit
to electron/electron
that referenced
this pull request
Jun 23, 2020
3 tasks
nornagon
added a commit
to electron/electron
that referenced
this pull request
Jun 23, 2020
nornagon
added a commit
to electron/electron
that referenced
this pull request
Jun 23, 2020
deepak1556
pushed a commit
to electron/electron
that referenced
this pull request
Jun 24, 2020
deepak1556
pushed a commit
to electron/electron
that referenced
this pull request
Jun 24, 2020
deepak1556
pushed a commit
to electron/electron
that referenced
this pull request
Jun 24, 2020
deepak1556
pushed a commit
to electron/electron
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the root certs to use NSS 3.53
should fix #33681
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes