Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix deprecation "End-of-Life" capitalization #33691

Merged
merged 1 commit into from Jun 2, 2020
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 1, 2020

Update the "End-of-Life" casing in the deprecation documentation for consistency. Similar to #26251.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Jun 1, 2020
@richardlau
Copy link
Member

I thought we linted for this?

@richardlau
Copy link
Member

I thought we linted for this?

@Trott I think these would have been caught by the linter prior to nodejs/remark-preset-lint-node#86?

@targos
Copy link
Member

targos commented Jun 2, 2020

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 2, 2020
Update the "End-of-Life" casing in the deprecation documentation
for consistency. Similar to nodejs#26251.

PR-URL: nodejs#33691
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 4, 2020

I thought we linted for this?

@Trott I think these would have been caught by the linter prior to nodejs/remark-preset-lint-node#86?

Bug identified. Fix coming soon, I think/hope.

Trott added a commit to Trott/remark-lint-prohibited-strings that referenced this pull request Jun 4, 2020
Trott added a commit to Trott/remark-lint-prohibited-strings that referenced this pull request Jun 4, 2020
Trott added a commit to Trott/remark-lint-prohibited-strings that referenced this pull request Jun 4, 2020
Trott added a commit to Trott/remark-preset-lint-node that referenced this pull request Jun 4, 2020
This fixes a bug that causes remark-preset-lint-node to miss some
errors.

Refs: nodejs/node#33691
Trott added a commit to nodejs/remark-preset-lint-node that referenced this pull request Jun 4, 2020
This fixes a bug that causes remark-preset-lint-node to miss some
errors.

Refs: nodejs/node#33691
Marlyfleitas added a commit to Marlyfleitas/Node-remark-preset-lint that referenced this pull request Aug 26, 2022
This fixes a bug that causes remark-preset-lint-node to miss some
errors.

Refs: nodejs/node#33691
patrickm68 added a commit to patrickm68/Node-preset-lint that referenced this pull request Sep 14, 2023
This fixes a bug that causes remark-preset-lint-node to miss some
errors.

Refs: nodejs/node#33691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants