Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix invalid regular expressions in case test-trace-exit #33769

Closed
wants to merge 1 commit into from
Closed

test: fix invalid regular expressions in case test-trace-exit #33769

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

Fixes: #30516 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 6, 2020
@legendecas legendecas mentioned this pull request Jun 6, 2020
Closed
4 tasks
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 6, 2020
@targos
Copy link
Member

targos commented Jun 6, 2020

Simple bug fix in a test... Fast-track?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31757/

@legendecas
Copy link
Member Author

Landed in 5590ee0

legendecas added a commit that referenced this pull request Jun 9, 2020
@legendecas
test: fix invalid regular expressions in case test-trace-exit
5590ee0 
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@legendecas legendecas closed this Jun 9, 2020
@legendecas legendecas deleted the test-trace-exit-regex branch June 9, 2020 06:55
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@legendecas @codebytere
test: fix invalid regular expressions in case test-trace-exit
b6e3616 
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@legendecas @codebytere
test: fix invalid regular expressions in case test-trace-exit
5261911 
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@legendecas @codebytere
test: fix invalid regular expressions in case test-trace-exit
c50bd2f 
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@legendecas @codebytere
test: fix invalid regular expressions in case test-trace-exit
8149b72 
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@legendecas @targos @nodejs-github-bot @lpinca @cjihrig @lundibundi