Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,http,http2: add http highlight grammar #33785

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions doc/api/http.md
Expand Up @@ -2060,13 +2060,13 @@ added: v0.1.90

**Only valid for request obtained from [`http.Server`][].**

Request URL string. This contains only the URL that is
present in the actual HTTP request. If the request is:
Request URL string. This contains only the URL that is present in the actual
HTTP request. If the request is (remember, each header line ends with `\r\n`
plus a final `\r\n` after the last one indicating the end of the header):

```http
GET /status?name=ryan HTTP/1.1\r\n
Accept: text/plain\r\n
\r\n
GET /status?name=ryan HTTP/1.1
Accept: text/plain
```

To parse the URL into its parts:
Expand Down
10 changes: 5 additions & 5 deletions doc/api/http2.md
Expand Up @@ -3025,13 +3025,13 @@ added: v8.4.0

* {string}

Request URL string. This contains only the URL that is
present in the actual HTTP request. If the request is:
Request URL string. This contains only the URL that is present in the actual
HTTP request. If the request is (remember, each header line ends with `\r\n`
plus a final `\r\n` after the last one indicating the end of the header):

```http
GET /status?name=ryan HTTP/1.1\r\n
Accept: text/plain\r\n
\r\n
GET /status?name=ryan HTTP/1.1
Accept: text/plain
```

Then `request.url` will be:
Expand Down
3 changes: 2 additions & 1 deletion doc/api_assets/README.md
Expand Up @@ -2,14 +2,15 @@

## highlight.pack.js

_Generated by [highlightjs.org/download][] on 2020-05-16._
_Generated by [highlightjs.org/download][] on 2020-06-07._

Grammars included in the custom bundle:

* Bash
* C
* C++
* CoffeeScript
* HTTP
* JavaScript
* JSON
* Markdown
Expand Down
2 changes: 1 addition & 1 deletion doc/api_assets/highlight.pack.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions doc/api_assets/hljs.css
Expand Up @@ -7,6 +7,7 @@
color: #333;
}

.hljs-attribute,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to have any unintended affect on the other existing code blocks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, these are the only two instances I was able to find. Something that does not yet have highlighting is the .hljs-attr class, which probably needs to happen at some point, but this is not the same as that.

.hljs-keyword {
color: #338;
}
Expand Down