doc: util.debuglog callback #33856
Closed
doc: util.debuglog callback #33856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
API came from #32260 |
|
I don't think it's really worth documenting this as it's purely an (internal) optimization. The callback isn't for determining whether debugging is enabled, in fact the argument passed to the callback is always a function. The callback is used to get a reference to a more optimized (by V8) debug function. |
|
@mscdex it is exposed publicly so it seems like it should be documented. will fixup the docs though |
bmeck
commented
Jun 12, 2020
bmeck
commented
Jun 12, 2020
|
@bmeck There are still a two or three things flagged in the GitHub interface that look like they are worth addressing. (Can't assign the new value to |
jasnell
approved these changes
Jun 14, 2020
bmeck
commented
Jun 15, 2020
bmeck
commented
Jun 15, 2020
bmeck
commented
Jun 15, 2020
bmeck
commented
Jun 15, 2020
|
@targos those should be fixed now, thanks |
rexagod
reviewed
Jun 20, 2020
rexagod
approved these changes
Jul 3, 2020
jasnell
pushed a commit
that referenced
this pull request
Jul 3, 2020
PR-URL: #33856 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 16f3b6a |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33856 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
PR-URL: #33856 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #33856 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist