Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: use and support non-empty DATA frame with END_STREAM flag #33875

Closed
wants to merge 14 commits into from
Closed

http2: use and support non-empty DATA frame with END_STREAM flag #33875

wants to merge 14 commits into from

Commits on Jun 18, 2020

  1. http2: use and support non-empty DATA frame with END_STREAM flag 

    Adds support for reading from a stream where the final frame is a non-empty
DATA frame with the END_STREAM flag set, instead of hanging waiting for another
frame. When writing to a stream, uses a END_STREAM flag on final DATA frame
instead of adding an empty DATA frame.

BREAKING: http2 client now expects servers to properly support END_STREAM flag

Fixes: nodejs#31309
Fixes: nodejs#33891
Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback
    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    ca21bd1 View commit details
    Browse the repository at this point in the history

  2. remove whitespace

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    1e35afd View commit details
    Browse the repository at this point in the history

  3. Update node_http2.cc

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    30b1c06 View commit details
    Browse the repository at this point in the history

  4. Update node_http2.cc

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    6f7c361 View commit details
    Browse the repository at this point in the history

  5. Update node_http2.cc

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    cbddeb6 View commit details
    Browse the repository at this point in the history

  6. Update node_http2.cc

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    acb5999 View commit details
    Browse the repository at this point in the history

  7. Update node_http2.cc

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    85cf722 View commit details
    Browse the repository at this point in the history

  8. http2: add "receive paused" debug native line

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    7bae5a5 View commit details
    Browse the repository at this point in the history

  9. http2: remove empty DATA frame

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    789cc1d View commit details
    Browse the repository at this point in the history

  10. http2: update tests

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    0c110d0 View commit details
    Browse the repository at this point in the history

  11. fix trailers flag detection

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    563a310 View commit details
    Browse the repository at this point in the history

  12. fix tests

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    327e9e8 View commit details
    Browse the repository at this point in the history

  13. add test

    @clshortfuse
    clshortfuse committed Jun 18, 2020
    Copy the full SHA
    58a3885 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. add state.shutdownWritableCalled

    @clshortfuse
    clshortfuse committed Jun 19, 2020
    Copy the full SHA
    1778fc6 View commit details
    Browse the repository at this point in the history