Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: always call callback on Http2ServerResponse#end #33911

Closed
wants to merge 2 commits into from
Closed

http2: always call callback on Http2ServerResponse#end #33911

wants to merge 2 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jun 16, 2020

Fixes: #28001

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Jun 16, 2020
lundibundi
lundibundi approved these changes Jun 16, 2020
View reviewed changes
lib/internal/http2/compat.js Outdated Show resolved Hide resolved
@rexagod @lundibundi
Update lib/internal/http2/compat.js
14fa43f 
Co-authored-by: Denys Otrishko <shishugi@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31907/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2020
@addaleax
Copy link
Member

addaleax commented Jun 19, 2020 •
edited

Landed in fdcd489 🎉

(Edit: Github won’t let me close this PR. Not sure what’s up with that, I’ll probably try again later?)

addaleax pushed a commit that referenced this pull request Jun 19, 2020
@rexagod @addaleax
http2: always call callback on Http2ServerResponse#end
fdcd489 
Fixes: #28001

PR-URL: #33911
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax closed this Jun 19, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@rexagod @codebytere
http2: always call callback on Http2ServerResponse#end
0752d23 
Fixes: #28001

PR-URL: #33911
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@rexagod @codebytere
http2: always call callback on Http2ServerResponse#end
c46543d 
Fixes: #28001

PR-URL: #33911
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@rexagod @codebytere
http2: always call callback on Http2ServerResponse#end
c60ffe6 
Fixes: #28001

PR-URL: #33911
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@rexagod @codebytere
http2: always call callback on Http2ServerResponse#end
75107e2 
Fixes: #28001

PR-URL: #33911
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@rexagod @codebytere
http2: always call callback on Http2ServerResponse#end
f999907 
Fixes: #28001

PR-URL: #33911
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mgabeler-lee-6rs mgabeler-lee-6rs mentioned this pull request Jul 28, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http compat won't always call callback on end method
5 participants
@rexagod @nodejs-github-bot @addaleax @lpinca @lundibundi