querystring: fix stringify for empty array #33918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
querystring
sapics
force-pushed
the
lib/fix-querystring-empty-array
branch
4 times, most recently
from
f194c8a
to
e334dbe
Compare
jasnell
approved these changes
Jun 19, 2020
addaleax
approved these changes
Jun 19, 2020
|
For whoever lands this: The commit message should start with |
addaleax
added
the
author ready
sapics
force-pushed
the
lib/fix-querystring-empty-array
branch
from
e334dbe
to
a117ec5
Compare
|
@addaleax Thanks for noticing! I replace commit message from "lib: fix querystring.stringify for empty array" to "querystring: fix stringify for empty array", and update title also. |
sapics
changed the title
jasnell
pushed a commit
that referenced
this pull request
Jun 24, 2020
PR-URL: #33918 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in d4a1c98 |
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
PR-URL: #33918 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33918 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33918 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33918 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33910
Currently
querystring.stringify({a:1, b:[]})return"a=1&"and
querystring.stringify({a:1})return"a=1"and
querystring.stringify({a:[], b:[]})return""If this PR is merged, first one will change to
querystring.stringify({a:1, b:[]})return"a=1".I think that this is better for consistency.
Checklist