Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix indentation of sources in ngtcp2.gyp #33938

Closed
wants to merge 1 commit into from
Closed

deps: fix indentation of sources in ngtcp2.gyp #33938

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 18, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
Copy link
Contributor Author

danbev commented Jun 18, 2020

CI: https://ci.nodejs.org/job/node-test-commit/39088/

@danbev danbev mentioned this pull request Jun 24, 2020
Closed
4 tasks
@danbev
Copy link
Contributor Author

danbev commented Jun 24, 2020

Closing this in favor of #34033.

@danbev danbev closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danbev @jasnell @addaleax @lpinca @gengjiawen @richardlau