Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an assertion failure at exit in the macOS app sandbox #33944

Closed
wants to merge 5 commits into from
Closed

Fix an assertion failure at exit in the macOS app sandbox #33944

wants to merge 5 commits into from

Commits on Jun 18, 2020

  1. src: tolerate EPERM returned from tcsetattr 

    macOS app sandbox makes tcsetattr return EPERM. The CHECK_EQ(0, err) here would fail when a sandboxed Node.js process is exiting. This commit fixes this issue.
    @branchseer
    branchseer committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    317621b View commit details
    Browse the repository at this point in the history

  2. test: add test for running in macOS app sandbox 

    Bare-bone command-line executables cannot run directly in the app sandbox. To test that Node.js is able to run in the sandbox (and to test the fix in 317621b), this commit creates a typical Cocoa app bundle, puts the node executable in it and calles Apple's codesign command to enable sandbox.
    @branchseer
    branchseer committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5f4f969 View commit details
    Browse the repository at this point in the history

  3. test: use process.execPath to get path of testing node

    @branchseer
    branchseer committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3cb770e View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. test: log codesign result (ci debug)

    @branchseer
    branchseer committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    d939f7f View commit details
    Browse the repository at this point in the history

  2. Revert "test: log codesign result (ci debug)" 

    This reverts commit d939f7f.
    @branchseer
    branchseer committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    59e434d View commit details
    Browse the repository at this point in the history