Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: fix multipleResolves in promisified timeouts/immediates #33949

Closed
wants to merge 2 commits into from
Closed

timers: fix multipleResolves in promisified timeouts/immediates #33949

wants to merge 2 commits into from

Conversation

lundibundi
Copy link
Member

After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko shishugi@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

/cc @jasnell @nodejs/timers

@lundibundi
timers: fix multipleResolves in promisified timeouts/immediates
4fa607f 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>
@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Jun 18, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31926/

jasnell
jasnell approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@jasnell jasnell mentioned this pull request Jun 18, 2020
Closed
4 tasks
lundibundi added a commit to lundibundi/node that referenced this pull request Jun 18, 2020
@lundibundi
test: print arguments passed to mustNotCall function
9dad0ba 
Refs: nodejs#33949 (comment)
Signed-off-by: Denys Otrishko <shishugi@gmail.com>
@lundibundi lundibundi mentioned this pull request Jun 18, 2020
Closed
4 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31928/

@github-actions github-actions bot mentioned this pull request Jun 19, 2020
Open
36 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/31931/ (:yellow_heart:)

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2020
This was referenced Jun 20, 2020
Open
Open
@ronag
Copy link
Member

ronag commented Jun 21, 2020

Landed in 64d22c3

@ronag ronag closed this Jun 21, 2020
ronag pushed a commit that referenced this pull request Jun 21, 2020
@lundibundi @ronag
timers: fix multipleResolves in promisified timeouts/immediates
64d22c3 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jun 22, 2020
Open
Open
jasnell pushed a commit that referenced this pull request Jun 24, 2020
@lundibundi @jasnell
test: print arguments passed to mustNotCall function
225a03c 
Refs: #33949 (comment)
Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33951
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere
Copy link
Member

@lundibundi could you please open a manual backport for this to v14.x-staging? it's conflict-heavy.

@addaleax
Copy link
Member

This depends on #33833, which is labelled dont-land-on-v14.x

codebytere pushed a commit that referenced this pull request Jun 27, 2020
@lundibundi @codebytere
test: print arguments passed to mustNotCall function
4a61013 
Refs: #33949 (comment)
Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33951
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@lundibundi @codebytere
test: print arguments passed to mustNotCall function
9037ab3 
Refs: #33949 (comment)
Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33951
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@lundibundi @codebytere
test: print arguments passed to mustNotCall function
7744f66 
Refs: #33949 (comment)
Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33951
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@lundibundi @codebytere
test: print arguments passed to mustNotCall function
f568a48 
Refs: #33949 (comment)
Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33951
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@lundibundi @targos
timers: fix multipleResolves in promisified timeouts/immediates
602e0f8 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: nodejs#33949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@lundibundi @targos
timers: fix multipleResolves in promisified timeouts/immediates
0ce52b7 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: nodejs#33949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@lundibundi @targos
timers: fix multipleResolves in promisified timeouts/immediates
290ce9f 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: nodejs#33949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 30, 2021
@lundibundi @targos
timers: fix multipleResolves in promisified timeouts/immediates
59a8425 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>

PR-URL: #33949
Backport-PR-URL: #38386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek left review comments

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lundibundi @nodejs-github-bot @ronag @codebytere @addaleax @jasnell @benjamingr @devsnek @targos