Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some typos #33973

Closed
wants to merge 1 commit into from
Closed

Some typos #33973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/guides/contributing/issues.md
View file
Open in desktop
Expand Up @@ -90,10 +90,10 @@ including whether the behavior being seen is a bug or a feature. This discussion
is part of the process and should be kept focused, helpful, and professional.

Short, clipped responses that provide neither additional context nor supporting
detail are not helpful or professional. To many, such responses are simply
details are not helpful or professional to many. Such responses are simply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
details are not helpful or professional to many. Such responses are simply
details are not helpful or professional. To many, Such responses are simply

I personally prefer the original sentence break here, but details definitely needs to be pluralized

annoying and unfriendly.

Contributors are encouraged to help one another make forward progress as much
Contributors are encouraged to help one another to make forward progress as much
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Contributors are encouraged to help one another to make forward progress as much
Contributors are encouraged to help one another make forward progress as much

I don't think this change needs to be made. The original sentence is grammatically correct.

as possible, empowering one another to solve issues collaboratively. If you
choose to comment on an issue that you feel either is not a problem that needs
to be fixed, or if you encounter information in an issue that you feel is
Expand Down