Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: remove custom Buffer pool for streams #33981

Closed
wants to merge 3 commits into from
Closed

fs: remove custom Buffer pool for streams #33981

wants to merge 3 commits into from
+33 −72

Commits on Jun 20, 2020

  1. fs: remove custom Buffer pool for streams 

    The performance benefit of using a custom pool are negligable.
Furthermore, it causes problems with Workers and transferrable.
Rather than further adding complexity for compat with Workers,
just remove the pooling logic.

Refs: nodejs#33880 (comment)
Fixes: nodejs#31733
    @ronag
    ronag committed Jun 20, 2020
    Copy the full SHA
    2bc17a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. fixup

    @ronag
    ronag committed Jun 21, 2020
    Copy the full SHA
    ca1d829 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. fixup

    @ronag
    ronag committed Jun 23, 2020
    Copy the full SHA
    2facf66 View commit details
    Browse the repository at this point in the history