doc: correct default values in http2 docs #33997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Jun 21, 2020
Trott
added
the
author ready
MrHeer
approved these changes
Jun 21, 2020
trivikr
approved these changes
Jun 22, 2020
jasnell
approved these changes
Jun 22, 2020
rexagod
approved these changes
Jun 22, 2020
|
Landed in 86cbad8 |
Trott
added a commit
that referenced
this pull request
Jun 23, 2020
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: #33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: #33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: #33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: #33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: #33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: #33997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http2 docs include invalid JavaScript values as defaults for three
options. The intention was increased clarity, but we specify valid
values everywhere else in our docs, so let's do that for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes