tools: remove superfluous regex in tools/doc/json.js #33998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Jun 22, 2020
Trott
added
the
author ready
|
I guess we need a regex team or something. 😆 Let's try: /ping @davisjam |
|
I agree that the new regex is equivalent to the previous version. (Happy to ponder other regexes as they come up ;-)) |
|
Landed in d408ee1 |
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: #33998 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: #33998 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: #33998 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: #33998 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: #33998 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead
that is only used in one regex where it is placed immediately before a
terminating $, thus rendering it meaningless.
I ran
make docwith this change and confirmed that the contents ofout/docwere unchanged.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes