Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: make MessagePort inherit from EventTarget #34057

Closed
wants to merge 8 commits into from

Commits on Jul 20, 2020

  1. test: delete invalid test

    This test has not been working correctly since at least a555be2.
    
    Since it tests internals, any replacement test might become invalid
    in a similar way.
    addaleax committed Jul 20, 2020
    Copy the full SHA
    11a940e View commit details
    Browse the repository at this point in the history
  2. events: expand NodeEventTarget functionality

    Enable `NodeEventTarget` as a base class for `MessagePort`,
    by enabling special processing of events for Node.js listeners,
    and removing implicit constructors/private properties so that
    classes can be made subclasses of `NodeEventTarget` after they
    are created.
    addaleax committed Jul 20, 2020
    Copy the full SHA
    0b2cd67 View commit details
    Browse the repository at this point in the history
  3. test: fixup worker + source map test

    The messaging code uses `Object.defineProperty()`, which accesses
    `value` on `Object.prototype` by default, so some calls to the
    getter here would actually be expected. Instead, make the list
    of accessed properties more specific to the tested source map
    code to avoid flakiness.
    
    Refs: https://twitter.com/addaleax/status/1276289101671608320
    addaleax committed Jul 20, 2020
    Copy the full SHA
    37fa701 View commit details
    Browse the repository at this point in the history
  4. worker: make MessagePort inherit from EventTarget

    Use `NodeEventTarget` to provide a mixed `EventEmitter`/`EventTarget`
    API interface.
    addaleax committed Jul 20, 2020
    Copy the full SHA
    6b1926f View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Copy the full SHA
    c9aabd6 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a61bd04 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    644932c View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    7cb1db7 View commit details
    Browse the repository at this point in the history