Commits on Jun 26, 2020

1. deps: V8: backport fb26d0bb1835 …

   Original commit message:
   
       [objects] Compact and shrink script_list
   
       So far creating scripts always grew the script_list without ever
       reusing cleared slots or shrinking. While this is probably not a
       problem with script_list in practice, this is still a memory leak.
   
       Fix this leak by using WeakArrayList::Append instead of AddToEnd.
       Append adds to the end of the array, but potentially compacts and
       shrinks the list as well. Other WeakArrayLists can use this method as
       well, as long as they are not using indices into this array.
   
       Bug: v8:10031
       Change-Id: If743c4cc3f8d67ab735522f0ded038b2fb43e437
       Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967385
       Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
       Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
       Cr-Commit-Position: refs/heads/master@{#65640}
   
   Refs: v8/v8@fb26d0b
   
   PR-URL: #33573
   Reviewed-By: Anna Henningsen <anna@addaleax.net>
   Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
   Reviewed-By: Shelley Vohr <codebytere@gmail.com>
   Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

   

   mmarchini authored and BethGriggs committed Jun 26, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 97a3f7b
   • Browse repository at this point

   Copy the full SHA

   97a3f7b View commit details

   Browse the repository at this point in the history

2. src: use symbol to store AsyncWrap resource …

   Use a symbol on the bindings object to store the public resource object,
   rather than a `v8::Global` Persistent. This has several advantages:
   
   - It’s harder to inadvertently create memory leaks this way.
     The garbage collector sees the `AsyncWrap` →  resource link like
     a regular JS property, and can collect the objects as a group,
     even if the resource object should happen to point back to the
     `AsyncWrap` object.
   - This will make it easier in the future to use `owner_symbol` for
     this purpose, which is generally the direction we should be moving
     the `async_hooks` API into (i.e. using more public objects instead
     of letting internal wires stick out).
   
   PR-URL: #31745
   Backport-PR-URL: #33962
   Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
   Reviewed-By: David Carlier <devnexen@gmail.com>
   Reviewed-By: Denys Otrishko <shishugi@gmail.com>
   Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
   Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
   Reviewed-By: James M Snell <jasnell@gmail.com>
   Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
   Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
   Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
   Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

   

   addaleax authored and BethGriggs committed Jun 26, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 30b0339
   • Browse repository at this point

   Copy the full SHA

   30b0339 View commit details

   Browse the repository at this point in the history

3. 2020-06-30, Version 12.18.2 'Erbium' (LTS) …

   Notable changes:
   
   - deps: V8: backport fb26d0bb1835 (Matheus Marchini)
     [#33573](#33573)
   - src: use symbol to store `AsyncWrap` resource (Anna Henningsen)
     [#31745](#31745)
   
   PR-URL: #34077

   

   BethGriggs committed Jun 26, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 412c618
   • Browse repository at this point

   Copy the full SHA

   412c618 View commit details

   Browse the repository at this point in the history