Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify O_EXCL text in fs.md #34096

Merged
merged 25 commits into from Jul 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b327d33
n-api: add version to wasm registration
devsnek Jun 25, 2020
95eecd5
doc: improve paragraph in esm.md
Trott Jun 26, 2020
90d5f35
doc: make minor improvements to paragraph in child_process.md
Trott Jun 26, 2020
da8a1ef
zlib: remove redundant variable in zlibBufferOnEnd
puzpuzpuz Jun 26, 2020
9e135ac
wasi: add reactor support
devsnek Jun 25, 2020
c23d2fd
src: allow embedders to disable esm loader
codebytere Jun 26, 2020
cb673e1
2020-06-30, Version 12.18.2 'Erbium' (LTS)
BethGriggs Jun 26, 2020
b613933
test: update test-child-process-spawn-loop for Python 3
richardlau Jun 26, 2020
68634d2
quic: remove redundant cast
gengjiawen Jun 27, 2020
204f20f
quic: minor cleanups in quic_buffer
jasnell Jun 26, 2020
8f4b4f2
stream: destroy wrapped streams on error
ronag Jun 28, 2020
312a4f3
net: fix bufferSize
ronag Jun 27, 2020
0edeeec
net: doc deprecate bufferSize
ronag Jun 28, 2020
eb8fc2b
2020-06-30, Version 14.5.0 (Current)
codebytere Jun 28, 2020
e20beaf
meta: fixup CODEOWNERS so it hopefully works
jasnell Jul 1, 2020
73a51bb
quic: cleanups in JS API
jasnell Jun 27, 2020
d603418
quic: cleanups for QuicSocket
jasnell Jun 30, 2020
def8e76
quic: fixup set_final_size
jasnell Jun 30, 2020
3bae2d5
quic: consolidate onSessionClose and onSessionSilentClose
jasnell Jun 30, 2020
b1fab88
quic: remove unused callback function
jasnell Jun 30, 2020
2afc1ab
quic: fixup constant exports, export all protocol error codes
jasnell Jun 30, 2020
b5fe31e
quic: avoid using private JS fields for now
jasnell Jun 30, 2020
31d6d9d
quic: reduce duplication of code
jasnell Jun 30, 2020
584fc7e
doc: clarify ambiguous rdev description
Trott Jun 28, 2020
8ff8c68
doc: clarify O_EXCL text in fs.md
Trott Jun 28, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Expand Up @@ -59,12 +59,12 @@

# quic

./deps/ngtcp2/* @nodejs/quic
./deps/nghttp3/* @nodejs/quic
./doc/api/quic.md @nodejs/quic
./lib/internal/quic/* @nodejs/quic
./src/node_bob* @nodejs/quic
./src/quic/* @nodejs/quic
/deps/ngtcp2/ @nodejs/quic
/deps/nghttp3/ @nodejs/quic
/doc/api/quic.md @nodejs/quic
/lib/internal/quic/ @nodejs/quic
/src/node_bob* @nodejs/quic
/src/quic/ @nodejs/quic

# modules

Expand Down
6 changes: 4 additions & 2 deletions CHANGELOG.md
Expand Up @@ -31,7 +31,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.4.0">14.4.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.5.0">14.5.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.4.0">14.4.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.3.0">14.3.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.2.0">14.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.1.0">14.1.0</a><br/>
Expand All @@ -57,7 +58,8 @@ release.
<a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.18.1">12.18.1</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.18.2">12.18.2</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.18.1">12.18.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.18.0">12.18.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.17.0">12.17.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.16.3">12.16.3</a><br/>
Expand Down
6 changes: 3 additions & 3 deletions doc/api/child_process.md
Expand Up @@ -194,9 +194,9 @@ metacharacters may be used to trigger arbitrary command execution.**
If a `callback` function is provided, it is called with the arguments
`(error, stdout, stderr)`. On success, `error` will be `null`. On error,
`error` will be an instance of [`Error`][]. The `error.code` property will be
the exit code of the child process while `error.signal` will be set to the
signal that terminated the process. Any exit code other than `0` is considered
to be an error.
the exit code of the process. By convention, any exit code other than `0`
indicates an error. `error.signal` will be the signal that terminated the
process.

The `stdout` and `stderr` arguments passed to the callback will contain the
stdout and stderr output of the child process. By default, Node.js will decode
Expand Down
2 changes: 1 addition & 1 deletion doc/api/cli.md
Expand Up @@ -1385,7 +1385,7 @@ Overriding this value to an empty string (`''`) will use the built-in REPL.

### `NODE_SKIP_PLATFORM_CHECK=value`
<!-- YAML
added: REPLACEME
added: v14.5.0
-->

If `value` equals `'1'`, the check for a supported platform is skipped during
Expand Down
2 changes: 1 addition & 1 deletion doc/api/crypto.md
Expand Up @@ -1216,7 +1216,7 @@ This can be called many times with new data as it is streamed.
<!-- YAML
added: v11.6.0
changes:
- version: REPLACEME
- version: v14.5.0
pr-url: https://github.com/nodejs/node/pull/33360
description: Instances of this class can now be passed to worker threads
using `postMessage`.
Expand Down
21 changes: 18 additions & 3 deletions doc/api/deprecations.md
Expand Up @@ -2722,9 +2722,9 @@ native modules. It was incomplete so far and instead it's better to rely upon
### DEP0143: `module.parent`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/32217
description: Documentation-only deprecation.
- version: v14.5.0
pr-url: https://github.com/nodejs/node/pull/33126
description: Runtime deprecation.
-->

Type: Documentation-only (supports [`--pending-deprecation`][])
Expand All @@ -2751,6 +2751,19 @@ const moduleParents = Object.values(require.cache)
.filter((m) => m.children.includes(module));
```

<a id="DEP0XXX"></a>
### DEP0XXX: `socket.bufferSize`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/REPLACEME
description: Documentation-only deprecation.
-->

Type: Documentation-only

[`socket.bufferSize`][] is just an alias for [`writable.writableLength`][].

[`--pending-deprecation`]: cli.html#cli_pending_deprecation
[`--throw-deprecation`]: cli.html#cli_throw_deprecation
[`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size
Expand Down Expand Up @@ -2824,6 +2837,7 @@ const moduleParents = Object.values(require.cache)
[`script.createCachedData()`]: vm.html#vm_script_createcacheddata
[`setInterval()`]: timers.html#timers_setinterval_callback_delay_args
[`setTimeout()`]: timers.html#timers_settimeout_callback_delay_args
[`socket.bufferSize`]: net.html#net_socket_buffersize
[`timeout.ref()`]: timers.html#timers_timeout_ref
[`timeout.refresh()`]: timers.html#timers_timeout_refresh
[`timeout.unref()`]: timers.html#timers_timeout_unref
Expand Down Expand Up @@ -2860,6 +2874,7 @@ const moduleParents = Object.values(require.cache)
[`util`]: util.html
[`worker.exitedAfterDisconnect`]: cluster.html#cluster_worker_exitedafterdisconnect
[`worker.terminate()`]: worker_threads.html#worker_threads_worker_terminate
[`writable.writableLength`]: stream.html#stream_writable_writablelength
[`zlib.bytesWritten`]: zlib.html#zlib_zlib_byteswritten
[Legacy URL API]: url.html#url_legacy_url_api
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
Expand Down
2 changes: 1 addition & 1 deletion doc/api/dgram.md
Expand Up @@ -399,7 +399,7 @@ if the socket is not connected.
<!-- YAML
added: v0.1.99
changes:
- version: REPLACEME
- version: v14.5.0
pr-url: https://github.com/nodejs/node/pull/22413
description: The `msg` parameter can now be any `TypedArray` or `DataView`.
- version: v8.0.0
Expand Down
2 changes: 1 addition & 1 deletion doc/api/dns.md
Expand Up @@ -96,7 +96,7 @@ The following methods from the `dns` module are available:
<!-- YAML
added: v8.3.0
changes:
- version: REPLACEME
- version: v14.5.0
pr-url: https://github.com/nodejs/node/pull/33472
description: The constructor now accepts an `options` object.
The single supported option is `timeout`.
Expand Down
2 changes: 1 addition & 1 deletion doc/api/errors.md
Expand Up @@ -1569,7 +1569,7 @@ failed.
<a id="ERR_MESSAGE_TARGET_CONTEXT_UNAVAILABLE"></a>
### `ERR_MESSAGE_TARGET_CONTEXT_UNAVAILABLE`
<!-- YAML
added: REPLACEME
added: v14.5.0
-->

A message posted to a [`MessagePort`][] could not be deserialized in the target
Expand Down
10 changes: 5 additions & 5 deletions doc/api/esm.md
Expand Up @@ -124,12 +124,12 @@ as ES modules and `.cjs` files are always treated as CommonJS.
### Package scope and file extensions

A folder containing a `package.json` file, and all subfolders below that folder
down until the next folder containing another `package.json`, is considered a
_package scope_. The `"type"` field defines how `.js` files should be treated
within a particular `package.json` file’s package scope. Every package in a
until the next folder containing another `package.json`, are a
_package scope_. The `"type"` field defines how to treat `.js` files
within the package scope. Every package in a
project’s `node_modules` folder contains its own `package.json` file, so each
project’s dependencies have their own package scopes. A `package.json` lacking a
`"type"` field is treated as if it contained `"type": "commonjs"`.
project’s dependencies have their own package scopes. If a `package.json` file
does not have a `"type"` field, the default `"type"` is `"commonjs"`.

The package scope applies not only to initial entry points (`node my-app.js`)
but also to files referenced by `import` statements and `import()` expressions.
Expand Down