Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: exit explicitly after printing V8 help #34136

Closed
wants to merge 1 commit into from
Closed

src: exit explicitly after printing V8 help #34136

wants to merge 1 commit into from

Commits on Jun 30, 2020

  1. src: exit explicitly after printing V8 help 

    V8 will not exit the process after handling --help anymore:
https://chromium-review.googlesource.com/c/v8/v8/+/2276276

As a drive-by fix, correctly return in the `print_bash_completion`
case as well.

Refs: nodejs#34135
Co-authored-by: Ulan Degenbaev <ulan@chromium.org>
    @addaleax @ulan
    addaleax and ulan committed Jun 30, 2020
    Copy the full SHA
    7b36cf1 View commit details
    Browse the repository at this point in the history