New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add n-api null checks for conversions #34142

Closed

gabrielschulhof wants to merge 1 commit into nodejs:master from gabrielschulhof:n-api-add-test-conversion-null-checks

Commits on Jun 30, 2020

test: add n-api null checks for conversions

Add assertions that conversion and coercion N-APIs return appropriate
error statuses when given `NULL`s for parameters they expect to not be
`NULL`.

For `napi_get_value_string_*` this also checks that it returns
`napi_string_expected` when passed a `napi_value` not containing a
string.

Gabriel Schulhof committed Jun 30, 2020