Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: introduce custom OWNERS file #34150

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
76 changes: 76 additions & 0 deletions OWNERS.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
---
# Node.js Project Codeowners

# 1. Codeowners must always be teams, never individuals
# 2. Each codeowner team should contain at least one TSC member
# 3. PRs touching any code with a codeowner must be signed off by at least one
# person on the code owner team.

./OWNERS.yml: ["@nodejs/tsc"]

# net

./deps/cares: ["@nodejs/net"]
./doc/api/dns.md: ["@nodejs/net"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything with dns in the filename should probably use @nodejs/dns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, I just got the CODEOWNERS we have on the repo today, uncommented the files/teams pairs that were commented due to the GitHub reviewers limitations, and converted the file to YAML. I didn't vet the teams assigned to each file/glob.

I like the suggestion of pinging @nodejs/dns here though.

./doc/api/dgram.md: ["@nodejs/net"]
./doc/api/net.md: ["@nodejs/net"]
./lib/dgram.js: ["@nodejs/net"]
./lib/dns.js: ["@nodejs/net"]
./lib/net.js: ["@nodejs/net", "@nodejs/quic"]
./lib/internal/dgram.js: ["@nodejs/net"]
./lib/internal/dns/*: ["@nodejs/net"]
./lib/internal/net.js: ["@nodejs/net"]
./lib/internal/socket_list.js: ["@nodejs/net"]
./lib/internal/js_stream_socket.js: ["@nodejs/net"]
./src/cares_wrap.h: ["@nodejs/net"]
./src/connect_wrap.*: ["@nodejs/net"]
./src/connection_wrap.*: ["@nodejs/net"]
./src/node_sockaddr*: ["@nodejs/net"]
./src/tcp_wrap.*: ["@nodejs/net"]
./src/udp_wrap.*: ["@nodejs/net"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/net is only three people, one of them inactive... Not a change suggestion, just an observation.


# tls/crypto

./lib/internal/crypto/*: ["@nodejs/crypto"]
./lib/internal/tls.js: ["@nodejs/crypto", "@nodejs/net"]
./lib/crypto.js: ["@nodejs/crypto"]
./lib/tls.js: ["@nodejs/crypto", "@nodejs/net"]
./src/node_crypto*: ["@nodejs/crypto"]
./src/node_crypto_common*: ["@nodejs/crypto", "@nodejs/quic"]

# http

./deps/llhttp/*: ["@nodejs/http", "@nodejs/net"]
./doc/api/http.md: ["@nodejs/http", "@nodejs/net"]
./lib/_http_*: ["@nodejs/http", "@nodejs/net"]
./lib/http.js: ["@nodejs/http", "@nodejs/net"]
./lib/https.js: ["@nodejs/crypto", "@nodejs/net", "@nodejs/http"]
./src/node_http_common*: ["@nodejs/http", "@nodejs/http2", "@nodejs/quic", "@nodejs/net"]
./src/node_http_parser.cc: ["@nodejs/http", "@nodejs/net"]

# http2

./deps/nghttp2/*: ["@nodejs/http2", "@nodejs/net"]
./doc/api/http2.md: ["@nodejs/http", "@nodejs/http2", "@nodejs/net"]
./lib/http2.js: ["@nodejs/http2", "@nodejs/net"]
./lib/internal/http2/*: ["@nodejs/http2", "@nodejs/net"]
./src/node_http2*: ["@nodejs/http2", "@nodejs/net"]
./src/node_mem*: ["@nodejs/http2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are aiming for compatibility with CODEOWNERS here, the CODEOWNERS format does not like the leading . at the start of the path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, the file was converted from our own CODEOWNERS. I don't mind removing the leading ./ from it though.


# quic

/deps/ngtcp2/: ["@nodejs/quic"]
/deps/nghttp3/: ["@nodejs/quic"]
/doc/api/quic.md: ["@nodejs/quic"]
/lib/internal/quic/: ["@nodejs/quic"]
/src/node_bob*: ["@nodejs/quic"]
/src/quic/: ["@nodejs/quic"]

# modules

./doc/api/modules.md: ["@nodejs/modules"]
./doc/api/esm.md: ["@nodejs/modules"]
./lib/module.js: ["@nodejs/modules"]
./lib/internal/modules/*: ["@nodejs/modules"]
./lib/internal/bootstrap/loaders.js: ["@nodejs/modules"]
./src/module_wrap*: ["@nodejs/modules", "@nodejs/vm"]