Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: recommend Python 3.8 to build on Windows #34182

Closed
wants to merge 2 commits into from
Closed

build: recommend Python 3.8 to build on Windows #34182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4310d26
build: recommend Python 3.8 to build on Windows
targos Jul 3, 2020
4fe9edd
Update .github/workflows/build-tarball.yml
targos Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-tarball.yml
View file
Open in desktop
Expand Up @@ -72,10 +72,10 @@ jobs:
run: |
git config --global core.autocrlf true
- uses: actions/checkout@v2
- name: Set up Python 2.7
- name: Set up Python 3.8
uses: actions/setup-python@v1
targos marked this conversation as resolved.
Show resolved Hide resolved
with:
python-version: 2.7
python-version: 3.8
- name: Environment Information
run: npx envinfo
- name: Download tarball
Expand Down
2 changes: 1 addition & 1 deletion BUILDING.md
View file
Open in desktop
Expand Up @@ -526,7 +526,7 @@ to run it again before invoking `make -j4`.

##### Option 1: Manual install

* [Python 2.7](https://www.python.org/downloads/)
* [Python 3.8](https://www.python.org/downloads/)
Copy link
Contributor

@cclauss cclauss Jul 3, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not https://www.microsoft.com/en-us/p/python-38/9mssztt1n39l ? It will prompt users as updates become available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's available on Windows 8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no. The System Requirements on MS store said only for Windows10

* The "Desktop development with C++" workload from
[Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) or
the "Visual C++ build tools" workload from the
Expand Down