Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: fix unintentional deprecation warning #34245

Closed
wants to merge 2 commits into from
Closed

domain: fix unintentional deprecation warning #34245

wants to merge 2 commits into from

Commits on Jul 7, 2020

  1. domain: fix unintentional deprecation warning 

    646e5a4 changed the way that the domain hook callback
is called. Previously, the callback was only used in the case that
async_hooks were *not* being used (since domains already integrate
with async hooks the way they should), and the corresponding
deprecation warning also only emitted in that case.

However, that commit didn’t move that condition along when the code
was ported from C++ to JS. As a consequence, the domain hook callback
was used when it wasn’t necessary to use it, and the deprecation
warning emitted accidentally along with it.

Refs: nodejs@646e5a4#diff-9f21ce1b9d6d46fdd07b969e8a04e140L192
Refs: nodejs@646e5a4#diff-e6db408e12db906ead6ddfac3de15a6fR119
Refs: nodejs#33801 (comment)
    @addaleax
    addaleax committed Jul 7, 2020
    Copy the full SHA
    c8e53bd View commit details
    Browse the repository at this point in the history

  2. fixup! domain: fix unintentional deprecation warning

    @addaleax
    addaleax committed Jul 7, 2020
    Copy the full SHA
    0d44c74 View commit details
    Browse the repository at this point in the history