Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: another round of refactorings #34247

Closed
wants to merge 16 commits into from
Closed

quic: another round of refactorings #34247

wants to merge 16 commits into from

Commits on Jul 7, 2020

  1. quic: additional minor cleanups in node_quic_session.h

    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    c6ce656 View commit details
    Browse the repository at this point in the history

  2. quic: remove unnecessary bool conversion 

    The argument will always be a boolean already
    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    51b7e64 View commit details
    Browse the repository at this point in the history

  3. quic: handle errors thrown / rejections in the session event 

    Errors thrown within the session event handler will be handled
by destroying the session (allowing a proper connection close
to be sent to the client peer). They will not crash the parent
QuicSocket by default. Instead, a `'sessionError'` event will
be emitted, allowing the error to be logged or handled.
    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    ebc8f5e View commit details
    Browse the repository at this point in the history

  4. quic: refactor/improve error handling for busy event 

    Also, change setServerBusy into a setter
    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    7a16657 View commit details
    Browse the repository at this point in the history

  5. quic: add tests confirming error handling for QuicSocket close event

    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    5858075 View commit details
    Browse the repository at this point in the history

  6. quic: refactor/improve QuicSocket ready event handling

    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    b056e91 View commit details
    Browse the repository at this point in the history

  7. quic: refactor/improve/document QuicSocket listening event

    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    8984458 View commit details
    Browse the repository at this point in the history

  8. quic: use Number() instead of bigint for QuicSocket stats

    @jasnell
    jasnell committed Jul 7, 2020
    Copy the full SHA
    8c93ce8 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. quic: unref timers again 

    0f97d60 accidentally removed this.

Refs: nodejs#34186
    @addaleax @jasnell
    addaleax authored and jasnell committed Jul 8, 2020
    Copy the full SHA
    71d0a18 View commit details
    Browse the repository at this point in the history

  2. quic: use getter/setter for stateless reset toggle

    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    5ce14b6 View commit details
    Browse the repository at this point in the history

  3. quic: cleanup QuicSocketFlags, used shared state struct 

    Some of the flags were no longer being used.

Switched to use an AliasedStruct for shared state to avoid
extraneous expensive JS=>C++ calls.

Removed unused QuicSocket option
    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    17089ea View commit details
    Browse the repository at this point in the history

  4. quic: proper custom inspect for QuicEndpoint

    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    14250d7 View commit details
    Browse the repository at this point in the history

  5. quic: proper custom inspect for QuicSocket

    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    89132be View commit details
    Browse the repository at this point in the history

  6. quic: proper custom inspect for QuicSession

    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    748deb5 View commit details
    Browse the repository at this point in the history

  7. quic: proper custom inspect for QuicStream

    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    34da6dd View commit details
    Browse the repository at this point in the history

  8. quic: remove no longer valid CHECK

    @jasnell
    jasnell committed Jul 8, 2020
    Copy the full SHA
    90fd223 View commit details
    Browse the repository at this point in the history