New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
child_process: allow promisified exec to be cancel #34249
Closed
metcoder95
wants to merge
25
commits into
nodejs:master
from
metcoder95:cancel-promisified-child-process
Closed
child_process: allow promisified exec to be cancel #34249
metcoder95
wants to merge
25
commits into
nodejs:master
from
metcoder95:cancel-promisified-child-process
Commits on Jan 12, 2021
-
child_process: allow promisified exec to be cancel
Using new experimental AbortController, add support for promisified exec to be cancelled.
-
child_process: fix validation issue
When doing a validation for the signal object, the validation was assuming wrongly that the signal object will always be there to apply the correct event-listener. The fix does a better validation to avoid fall in "addEventListener is not a function"
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Jan 14, 2021
Commits on Jan 18, 2021
Commits on Jan 21, 2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.