Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add changes metadata to TLS newSession event #34294

Closed
wants to merge 1 commit into from
Closed

doc: add changes metadata to TLS newSession event #34294

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Not really relevant anymore, just for completeness.

Refs: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jul 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32390/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32395/

This was referenced Jul 18, 2020
Open
Open
tniessen added a commit that referenced this pull request Jul 19, 2020
@tniessen
doc: add changes metadata to TLS newSession event
9cbfaba 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen
Copy link
Member Author

Landed in 9cbfaba, thank you for reviewing.

@tniessen tniessen closed this Jul 19, 2020
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2020
This was referenced Jul 20, 2020
Open
Open
Open
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@tniessen @cjihrig
doc: add changes metadata to TLS newSession event
1f7194c 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 23, 2020
Open
6 tasks
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@tniessen @MylesBorins
doc: add changes metadata to TLS newSession event
1083073 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@tniessen @addaleax
doc: add changes metadata to TLS newSession event
692a23b 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@tniessen @addaleax
doc: add changes metadata to TLS newSession event
88bd124 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tniessen @nodejs-github-bot @jasnell @lpinca