Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: try to wait for flush to complete before 'finish' #34314

Closed
wants to merge 2 commits into from
Closed

stream: try to wait for flush to complete before 'finish' #34314

wants to merge 2 commits into from

Commits on Jul 11, 2020

  1. stream: try to wait for flush to complete before 'finish' 

    Due to compat reasons Transform streams don't always wait
for flush to complete before finishing the stream.

Try to wait when possible, i.e. when the user does not
override _final.

Fixes: nodejs#34274
    @ronag
    ronag committed Jul 11, 2020
    Copy the full SHA
    0391515 View commit details
    Browse the repository at this point in the history

  2. fixup

    @ronag
    ronag committed Jul 11, 2020
    Copy the full SHA
    0e5a7d5 View commit details
    Browse the repository at this point in the history