Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http2-reset-flood #34318

Closed
wants to merge 2 commits into from
Closed

test: fix flaky test-http2-reset-flood #34318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e95a46
test: fix flaky test-http2-reset-flood
Trott Jul 12, 2020
a2457fe
fixup! test: fix flaky test-http2-reset-flood
Trott Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/parallel/parallel.status
View file
Open in desktop
Expand Up @@ -5,8 +5,6 @@ prefix parallel
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/29802
test-http2-reset-flood: PASS,FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/32863
Expand Down Expand Up @@ -46,8 +44,6 @@ test-crypto-keygen: SKIP
[$system==freebsd]
# https://github.com/nodejs/node/issues/31727
test-fs-stat-bigint: PASS,FLAKY
# https://github.com/nodejs/node/issues/29802
test-http2-reset-flood: PASS,FLAKY
# https://github.com/nodejs/node/issues/28803
test-stdout-close-catch: PASS,FLAKY
# https://github.com/nodejs/node/issues/31280
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-reset-flood.js
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ if (process.env.HAS_STARTED_WORKER) {
process.env.HAS_STARTED_WORKER = 1;
const worker = new Worker(__filename).on('message', common.mustCall((port) => {
const h2header = Buffer.alloc(9);
const conn = net.connect(port);
const conn = net.connect({ port, allowHalfOpen: true });

conn.write('PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n');

Expand Down