test: fix flaky test-net-connect-econnrefused #34330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pummel tests are not (yet) run in regular CI, but here is CI stress test on master showing the test is flaky: https://ci.nodejs.org/job/node-stress-single-test/113/ ...and here is a CI stress test with this change showing the test is now reliable: |
richardlau
approved these changes
Jul 13, 2020
Trott
added
the
author ready
|
@nodejs/testing This is ready to land but needs a second review. |
Trott
added
the
flaky-test
addaleax
approved these changes
Jul 15, 2020
|
Landed in e44855d |
Trott
added a commit
that referenced
this pull request
Jul 15, 2020
Test is flaky in CI with `common.PORT` but not flaky if a port is determined from createServer() first. PR-URL: #34330 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Test is flaky in CI with `common.PORT` but not flaky if a port is determined from createServer() first. PR-URL: #34330 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Test is flaky in CI with `common.PORT` but not flaky if a port is determined from createServer() first. PR-URL: #34330 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Test is flaky in CI with `common.PORT` but not flaky if a port is determined from createServer() first. PR-URL: #34330 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Test is flaky in CI with `common.PORT` but not flaky if a port is determined from createServer() first. PR-URL: #34330 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is flaky in CI with
common.PORTbut not flaky if a port isdetermined from createServer() first.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes