Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add quic to github action #34336

Closed
wants to merge 2 commits into from
Closed

build: add quic to github action #34336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d81099b
build: add quic to github action
gengjiawen Jul 13, 2020
88b77fa
quic: fix build for macOS
gengjiawen Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-windows.yml
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ env:
FLAKY_TESTS: dontcare

jobs:
build-windows:
build-windows-with-quic:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -24,4 +24,4 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: ./vcbuild.bat
run: ./vcbuild.bat experimental-quic
15 changes: 15 additions & 0 deletions .github/workflows/test-linux.yml
View file
Open in desktop
Expand Up @@ -25,3 +25,18 @@ jobs:
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"

test-linux-with-quic:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v1
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --experimental-quic"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
4 changes: 2 additions & 2 deletions .github/workflows/test-macos.yml
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ env:
FLAKY_TESTS: dontcare

jobs:
test-macOS:
test-macOS-with-quic:
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -22,6 +22,6 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j8 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j8 V=1 CONFIG_FLAGS="--error-on-warn --experimental-quic"
- name: Test
run: make run-ci -j8 V=1 TEST_CI_ARGS="-p dots"
4 changes: 2 additions & 2 deletions src/quic/node_quic_stream.cc
View file
Open in desktop
Expand Up @@ -160,11 +160,11 @@ int QuicStream::DoShutdown(ShutdownWrap* req_wrap) {

CHECK_NULL(shutdown_done_);
CHECK_NOT_NULL(req_wrap);
shutdown_done_ = std::move([=](int status) {
shutdown_done_ = [=](int status) {
CHECK_NOT_NULL(req_wrap);
shutdown_done_ = nullptr;
req_wrap->Done(status);
});
};

QuicSession::SendSessionScope send_scope(session());

Expand Down