Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not crash if ToggleAsyncHook fails during termination #34362

Closed
wants to merge 2 commits into from
Closed

src: do not crash if ToggleAsyncHook fails during termination #34362

wants to merge 2 commits into from

Commits on Jul 14, 2020

  1. src: do not crash if ToggleAsyncHook fails during termination 

    In the termination case, we should not crash. There’s also no harm
being done by ignoring the termination exception here, since the
thread is about to be torn down anyway.

Also, add a guard against running this during shutdown. That is the
likely cause of nodejs#34361.

Fixes: nodejs#34361
    @addaleax
    addaleax committed Jul 14, 2020
    Copy the full SHA
    643a109 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. fixup! src: do not crash if ToggleAsyncHook fails during termination

    @addaleax
    addaleax committed Jul 17, 2020
    Copy the full SHA
    9a084b1 View commit details
    Browse the repository at this point in the history