Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,tools: use .then(common.mustCall()) for all async IIFEs + linter rule #34363

Closed
wants to merge 3 commits into from
Closed

test,tools: use .then(common.mustCall()) for all async IIFEs + linter rule #34363

wants to merge 3 commits into from

Commits on Jul 14, 2020

  1. test: use .then(common.mustCall()) for all async IIFEs 

    This makes sure that all async functions finish as expected.
    @addaleax
    addaleax committed Jul 14, 2020
    Copy the full SHA
    ee5488d View commit details
    Browse the repository at this point in the history

  2. tools: add linting rule for async IIFEs 

    The result of an async IIFE should always be handled in our tests,
typically by adding `.then(common.mustCall())` to verify that the
async function actually finishes executing at some point.
    @addaleax
    addaleax committed Jul 14, 2020
    Copy the full SHA
    1c91794 View commit details
    Browse the repository at this point in the history

  3. fixup! tools: add linting rule for async IIFEs

    @addaleax
    addaleax committed Jul 14, 2020
    Copy the full SHA
    f0b8559 View commit details
    Browse the repository at this point in the history