Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typos in n-api, tls and worker_threads #34419

Closed
wants to merge 2 commits into from
Closed

doc: fix typos in n-api, tls and worker_threads #34419

wants to merge 2 commits into from

Conversation

jucke
Copy link
Contributor

@jucke jucke commented Jul 18, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 18, 2020
@jucke
Copy link
Contributor Author

jucke commented Jul 18, 2020

Thanks for approving @Trott

I'm wondering if I need to do anything to have the CI check pass? Looks like "Make tarball" task failed in "Build from tarball / build-tarball (pull_request)" https://github.com/nodejs/node/pull/34419/checks?check_run_id=885058504

@Trott
Copy link
Member

Trott commented Jul 18, 2020

Thanks for approving @Trott

I'm wondering if I need to do anything to have the CI check pass? Looks like "Make tarball" task failed in "Build from tarball / build-tarball (pull_request)" https://github.com/nodejs/node/pull/34419/checks?check_run_id=885058504

Nothing you need to do. GitHub Actions CI is advisory only. We have a separate Jenkins CI we use for code changes. For doc changes like this, as long as the linter jobs pass in GitHub Actions, it's usually good to go.

There's an issue open suggesting getting rid of the tarball jobs if we can't fix them. #34123

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2020
@addaleax
Copy link
Member

Landed in 50bc7ad...ca60f5f, and thanks for the pull request! 🎉

@addaleax addaleax closed this Jul 20, 2020
addaleax pushed a commit that referenced this pull request Jul 20, 2020
@jucke @addaleax
doc: fix typos in n-api, tls and worker_threads
0c6ac2d 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jul 20, 2020
@jucke @addaleax
doc: fix line length in worker_threads.md
ca60f5f 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@jucke @cjihrig
doc: fix typos in n-api, tls and worker_threads
8981e0c 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@jucke @cjihrig
doc: fix line length in worker_threads.md
8a9770d 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@jucke @MylesBorins
doc: fix typos in n-api, tls and worker_threads
d67a2b8 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@jucke @MylesBorins
doc: fix line length in worker_threads.md
905e3d1 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Nov 3, 2020
@jucke @codebytere
doc: fix typos in n-api, tls and worker_threads
83811fa 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Nov 3, 2020
@jucke @codebytere
doc: fix line length in worker_threads.md
5cb86f2 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@jucke @MylesBorins
doc: fix typos in n-api, tls and worker_threads
fb9b66b 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@jucke @MylesBorins
doc: fix line length in worker_threads.md
b644ab6 
PR-URL: #34419
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

@MrHeer MrHeer MrHeer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jucke @Trott @addaleax @lpinca @trivikr @MrHeer @nodejs-github-bot