Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mark Node.js 13 as End-of-Life #34436

Closed
wants to merge 1 commit into from
Closed

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 20, 2020

Remove the "Current" label for Node.js 13 in the CHANGELOG.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Remove the "Current" label for Node.js 13 in the CHANGELOG.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 20, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 20, 2020
@MylesBorins
Copy link
Member

fast track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 20, 2020
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax pushed a commit that referenced this pull request Jul 20, 2020
Remove the "Current" label for Node.js 13 in the CHANGELOG.

PR-URL: #34436
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@addaleax
Copy link
Member

Landed in 01bd810

@addaleax addaleax closed this Jul 20, 2020
@aduh95 aduh95 deleted the patch-3 branch July 20, 2020 16:42
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Remove the "Current" label for Node.js 13 in the CHANGELOG.

PR-URL: #34436
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Remove the "Current" label for Node.js 13 in the CHANGELOG.

PR-URL: #34436
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants