Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot #34454

Closed
wants to merge 1 commit into from
Closed

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot #34454

wants to merge 1 commit into from

Commits on Jul 22, 2020

  1. build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot 

    Otherwise the build would fail with
`./configure --experimental-quic --ninja` as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See nodejs#31074.
    @joyeecheung
    joyeecheung committed Jul 22, 2020
    Copy the full SHA
    e4d50ab View commit details
    Browse the repository at this point in the history