console: document the behavior of console.assert() #34501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
console
|
@addaleax there are some minor changes to the docs. Please, take a look when you have a spare minute :) |
addaleax
approved these changes
Jul 23, 2020
devsnek
reviewed
Jul 23, 2020
ghost
force-pushed
the
console-assert-docs
branch
from
59dcba6
to
2b11204
Compare
|
@devsnek I made the requested changes. Please, review :) |
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert
ghost
force-pushed
the
console-assert-docs
branch
from
2b11204
to
96679f6
Compare
himself65
approved these changes
Jul 28, 2020
himself65
pushed a commit
that referenced
this pull request
Jul 28, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
|
Landed in 4cee226 |
codebytere
pushed a commit
that referenced
this pull request
Aug 5, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a description and an example of
console.assert()call with no arguments. If called this way, the method should output:Assertion failed.Fixes: #34500
Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message
Refs: https://console.spec.whatwg.org/#assert
Checklist