async_hooks: avoid unneeded AsyncResource creation #34616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
async_hooks
addaleax
approved these changes
Aug 3, 2020
Qard
approved these changes
Aug 3, 2020
vdeturckheim
approved these changes
Aug 4, 2020
|
@Flarna there is a conflict in |
puzpuzpuz
approved these changes
Aug 4, 2020
Inspired by the callstack at nodejs#34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: nodejs#34556 (comment)
Flarna
force-pushed
the
async-local-no-unneeded-resource
branch
from
048632c
to
5eb30aa
Compare
This comment has been minimized.
This comment has been minimized.
Flarna
added
the
author ready
Flarna
changed the title
Qard
approved these changes
Aug 4, 2020
This was referenced Aug 5, 2020
Flarna
added a commit
that referenced
this pull request
Aug 6, 2020
Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) PR-URL: #34616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
|
Landed in 4824988 |
This was referenced Aug 7, 2020
addaleax
pushed a commit
that referenced
this pull request
Aug 8, 2020
Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) PR-URL: #34616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Aug 11, 2020
Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) PR-URL: #34616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) PR-URL: #34616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the callstack at #34556 (comment)
If the wanted store is equal to the active store it's not needed to create an AsyncResource.
Refs: #34556 (comment)
fyi @vdeturckheim @puzpuzpuz @Qard