Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: improve property descriptors in als.bind #34620

Closed
wants to merge 1 commit into from
Closed

async_hooks: improve property descriptors in als.bind #34620

wants to merge 1 commit into from

Commits on Aug 4, 2020

  1. [async_hooks] improve property descriptors in als.bind 

    The length property should be non enumerable to match behavior of
normal functions.

The asyncResource property is enumerable and therefore it should be
also writable to avoid issues like there:
nodejs#30932 (comment)

Both properties should be configurable.

Refs: nodejs#34574
    @Flarna
    Flarna committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    ccc0467 View commit details
    Browse the repository at this point in the history